fix(26338): replace chartsInScope references at import time#26389
fix(26338): replace chartsInScope references at import time#26389rdubois-kh wants to merge 3 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
john-bodley
left a comment
john-bodley
left a comment
There was a problem hiding this comment.
Thanks @rdubois-kh for the fix.
@betodealmeida @hughhhh et al. would you mind reviewing this? Sadly I don't have much context on the import/export logic.
| ] | ||
|
|
||
| charts_in_scope = native_filter.get("chartsInScope", []) | ||
| if charts_in_scope: |
There was a problem hiding this comment.
| if charts_in_scope: | |
| if charts_in_scope := native_filter.get("chartsInScope", []): |
There was a problem hiding this comment.
@rdubois-kh curious your take on the suggestion, and @john-bodley wondering if you see this as blocking.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26389 +/- ##
==========================================
- Coverage 69.14% 69.14% -0.01%
==========================================
Files 1946 1946
Lines 75989 75992 +3
Branches 8479 8479
==========================================
+ Hits 52544 52546 +2
- Misses 21266 21267 +1
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing/reopening to kick-start CI. Also, @betodealmeida if you could review or nominate someone else, we'd appreciate it! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26389 +/- ##
==========================================
- Coverage 69.14% 69.14% -0.01%
==========================================
Files 1946 1946
Lines 75989 75992 +3
Branches 8479 8479
==========================================
+ Hits 52544 52546 +2
- Misses 21266 21267 +1
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@eschutho / @betodealmeida still hoping someone with more context on import/export can help review this :) |
…26338/fix-charts-in-scope-references
|
All, as mentioned in #26338, a new commit has been added to the PR to make the charts references fix more complete as I missed a couple of locations where references were not updated at import time. I guess the PR is re-ready for being reviewed. Thanks in advance. |
|
Looks like this will need a rebase... hopefully we can get it to pass CI, and get this across the finish line finally. |
|
/korbit-review |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Incorrect use of double underscore prefix ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/commands/dashboard/importers/v1/utils.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| def __fix_charts_references_in_scope( | ||
| configuration: dict[str, Any], charts_map: dict[int, int] | ||
| ) -> dict[str, Any]: |
There was a problem hiding this comment.
Incorrect use of double underscore prefix 
Tell me more
What is the issue?
Function name uses double underscores which in Python implies name mangling, but this is not a class method where that would be appropriate.
Why this matters
Double underscores can make the function harder to import/reference and suggest private class method behavior when this is just a module-level utility function.
Suggested change ∙ Feature Preview
def _fix_charts_references_in_scope(
configuration: dict[str, Any], charts_map: dict[int, int]
) -> dict[str, Any]:Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
|
This PR hasn't been updated in a long time and is in need of a rebase. We'll mark it as draft, but please set it as 'ready for review' when it's been brought up to speed. |
5 participants
SUMMARY
See the description here: #26338
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION