Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Includes 90° x-axis label rotation #26207

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: Includes 90° x-axis label rotation #26207

merged 2 commits into from
Dec 7, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Includes 90° x-axis label rotation by default, as opposed to requiring users to input the value, as it's frequently used for charts with many data points.

Check #26159 for more context.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Dec 7, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f68dd82) 69.19% compared to head (eb4eed9) 69.19%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #26207   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files        1944     1944           
  Lines       75927    75927           
  Branches     8451     8451           
=======================================
  Hits        52534    52534           
  Misses      21208    21208           
  Partials     2185     2185
Flag Coverage Δ
javascript 56.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfirke
sfirke approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this cover bar charts? I didn't see "bar" on the page but maybe it's called something else.

@michael-s-molina
Copy link
Member Author

LGTM. Does this cover bar charts? I didn't see "bar" on the page but maybe it's called something else.

Now it does 😆

john-bodley
john-bodley reviewed Dec 7, 2023
View reviewed changes
superset-frontend/plugins/plugin-chart-echarts/src/Bubble/controlPanel.tsx
@@ -138,6 +138,7 @@ const config: ControlPanelConfig = {
choices: [
[0, '0°'],
[45, '45°'],
[90, '90°'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina is the last choice assigned the default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The default is defined by the default property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I misread your PR description. I initially read it as you were setting 90° as the default as opposed to adding it as one of the default options.

@michael-s-molina michael-s-molina merged commit 39c6488 into apache:master Dec 7, 2023
26 checks passed
villebro
villebro reviewed Dec 7, 2023
View reviewed changes
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx
@@ -184,6 +184,7 @@ const config: ControlPanelConfig = {
choices: [
[0, '0°'],
[45, '45°'],
[90, '90°'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of duplication here.. Could we move xAxisLabelRotation into controls.ts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just one example of the many code duplication in the ECharts plugins. I'm planning to improve all this once the migrations are complete.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If centralizing this now is easy (which I assume it should be), I'd probably just do this right away to get it out of the way. But if you prefer to do it later that's also ok.

villebro
villebro reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but I'd still recommend centralizing the control to leave the codebase slightly DRYer

edit: oops, I didn't notice this was already merged 😆

@michael-s-molina michael-s-molina mentioned this pull request Dec 7, 2023
Merged
9 tasks
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Dec 8, 2023
michael-s-molina added a commit that referenced this pull request Dec 8, 2023
@michael-s-molina
fix: Includes 90° x-axis label rotation (#26207)
2532fa5
michael-s-molina added a commit that referenced this pull request Dec 8, 2023
@michael-s-molina
fix: Includes 90° x-axis label rotation (#26207)
fb50819 
(cherry picked from commit 39c6488)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@michael-s-molina @josedev-union
fix: Includes 90° x-axis label rotation (apache#26207)
77afda2 
(cherry picked from commit 39c6488)
@mistercrunch mistercrunch added 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@michael-s-molina @sfirke
fix: Includes 90° x-axis label rotation (apache#26207)
4576f96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley left review comments

@villebro villebro villebro left review comments

@sfirke sfirke sfirke approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.0.3 🍒 3.0.4 🍒 3.1.0 🍒 3.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michael-s-molina @john-bodley @sfirke @villebro @mistercrunch