Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart): Added Cote d'Ivoire to countries map #25724

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(chart): Added Cote d'Ivoire to countries map #25724

wants to merge 2 commits into from

Conversation

dykoffi
Copy link

@dykoffi dykoffi commented Oct 20, 2023

SUMMARY

Added Cote d'Ivoire / Ivory coast (CIV) to countries map

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Texte alternatif de l'image

TESTING INSTRUCTIONS

(https://superset.apache.org/docs/miscellaneous/country-map-tools/)

github-actions[bot]
github-actions bot reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@dykoffi dykoffi changed the title Feat(chart): Added Cote d'Ivoire / Ivory coast (CIV) to countries map feat(chart): Added Cote d'Ivoire to countries map Oct 20, 2023
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Oct 20, 2023
@john-bodley
Copy link
Member

Thanks @dykoffi for the change. Would you mind also following the instructions in this notebook?

@dykoffi
Copy link
Author

dykoffi commented Oct 20, 2023 •
edited
Loading

Thanks @dykoffi for the change. Would you mind also following the instructions in this notebook?

I've already run all the cells in the notebook, but some cells return errors. So I executed the cells needed to download the geojson after adding the country to the list.

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 23, 2023
@rusackas rusackas self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rusackas rusackas

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dykoffi @john-bodley @rusackas