-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dataset): resizable dataset layout left column #24829
fix(dataset): resizable dataset layout left column #24829
Conversation
182a087
to
7b8401a
Compare
7b8401a
to
4f43aea
Compare
Codecov Report
@@ Coverage Diff @@
## master #24829 +/- ##
==========================================
- Coverage 68.99% 68.99% -0.01%
==========================================
Files 1903 1903
Lines 74072 74073 +1
Branches 8193 8193
==========================================
- Hits 51107 51106 -1
Misses 20844 20844
- Partials 2121 2123 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -25,22 +25,22 @@ export const StyledLayoutWrapper = styled.div` | |||
background-color: ${({ theme }) => theme.colors.grayscale.light5}; | |||
`; | |||
|
|||
const Column = styled.div` | |||
const Column = styled.div<{ width?: number }>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that LeftColumn
and RightColumn
are pretty much overriding the properties of Column
, could you remove Column
? I think it will be way more readable.
export const LeftColumn = styled.div<{ theme: SupersetTheme; width?: number }>`
width: ${({ theme, width }) => width ?? theme.gridUnit * 80}px;
height: auto;
flex-direction: column;
`;
export const RightColumn = styled.div`
width: auto;
height: auto;
display: flex;
flex: 1 1 auto;
flex-direction: column;
`;
adjust flex-grow to handle edge cases
@michael-s-molina I updated the styles as you suggested. could you review this pr again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up |
@lyndsiWilliams Ephemeral environment spinning up at http://54.188.162.116:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 6ff7fae)
SUMMARY
Since #24599 introduced the TableSelector in dataset left column, it also collapses the overflowing (long) table names like before SQLLab editor.. This commit also introduces the Resizable Leftbar in dataset layout to fix the problem as SQL Lab does.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--resizable-left-column.mov
Before:
before--resizable-column.mov
TESTING INSTRUCTIONS
Go to "Add Dataset" and choose a schema which contains a long table name
ADDITIONAL INFORMATION