Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes getUiOverrideRegistry #24330

Merged
merged 2 commits into from
Jun 9, 2023
Merged

chore: Removes getUiOverrideRegistry #24330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c608897
chore: Removes getUiOverrideRegistry
michael-s-molina Jun 8, 2023
27d20dd
Adds a breaking change text
michael-s-molina Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ assists people when migrating to a new version.

### Breaking Changes

- [24330](https://github.com/apache/superset/pull/24330) Removes `getUiOverrideRegistry` from `ExtensionsRegistry`.
- [23933](https://github.com/apache/superset/pull/23933) Removes the deprecated Multiple Line Charts.
- [23741](https://github.com/apache/superset/pull/23741) Migrates the TreeMap chart and removes the legacy Treemap code.
- [23712](https://github.com/apache/superset/pull/23712) Migrates the Pivot Table v1 chart to v2 and removes v1 code.
Expand Down
4 changes: 0 additions & 4 deletions superset-frontend/packages/superset-ui-core/src/ui-overrides/ExtensionsRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ class ExtensionsRegistry extends TypedRegistry<Extensions> {
}

export const getExtensionsRegistry = makeSingleton(ExtensionsRegistry, {});

// Exporting this under the old name for backwards compatibility.
// After downstream folks have migrated to `getExtensionsRegistry`, we should remove this.
export const getUiOverrideRegistry = getExtensionsRegistry;
6 changes: 3 additions & 3 deletions superset-frontend/src/dashboard/components/Header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
FeatureFlag,
t,
getSharedLabelColor,
getUiOverrideRegistry,
getExtensionsRegistry,
} from '@superset-ui/core';
import { Global } from '@emotion/react';
import { isFeatureEnabled } from 'src/featureFlags';
Expand Down Expand Up @@ -58,7 +58,7 @@ import { PageHeaderWithActions } from 'src/components/PageHeaderWithActions';
import { DashboardEmbedModal } from '../DashboardEmbedControls';
import OverwriteConfirm from '../OverwriteConfirm';

const uiOverrideRegistry = getUiOverrideRegistry();
const extensionsRegistry = getExtensionsRegistry();

const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
Expand Down Expand Up @@ -495,7 +495,7 @@ class Header extends React.PureComponent {
dashboardTitleChanged(updates.title);
};

const NavExtension = uiOverrideRegistry.get('dashboard.nav.right');
const NavExtension = extensionsRegistry.get('dashboard.nav.right');

return (
<div
Expand Down