Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Disable Select All on table selector #24120

Merged
merged 1 commit into from
May 18, 2023

Conversation

justinpark
Copy link
Member

SUMMARY

After #22084 merged, all SyncSelect has "Select All" option including a database selector. This change easily hits the tens (and can be thousands) of table preview fetches since the option triggers the preview request.
This commit disables the "Select All" option for TableSelector to resolve the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screenshot 2023-05-18 at 10 24 20 AM

Before:

Screenshot 2023-05-18 at 10 23 28 AM

TESTING INSTRUCTIONS

Go to SQLLab and verify that no options for "Select All" in table selector

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 5159861 into apache:master May 18, 2023
justinpark added a commit to airbnb/superset-fork that referenced this pull request May 18, 2023
@giftig
Copy link
Contributor

giftig commented May 19, 2023

Not sure if this just happened very, very fast or we both coincidentally spotted the same thing but I was just coming here to raise this PR after raising a discussion about it yesterday: #24115. Thanks for fixing this.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants