chore: relax Flask version constraint #23927
Conversation
Flask 2.1 no longer seems to be receiving updates. In order to keep receveiving critical Flask updates, the upper version constraint for Flask should be raised to a compatible newer version. I picked Flask 2.2 as the compatible version. This only required addressing one single old Flask 2.0 deprecation warning which is now a removed function in Flask 2.2
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks for this PR! Try to fix the CI tests. |
I confirmed that both, cache_control=0 and max_age=0 are resulting in the same 'Cache-Control: no-cache, max-age=0' response header.
|
I missed a few Mypy configuration looks broken to me though. I'm not sure if Mypy will even work the way we need it to work inside of pre-commit. Basically the problem is that some dependencies (e.g. Flask since version 2.0) have stubs include in their main distribution, while other dependencies require stubs to be installed vie the typeshed distribution. (i.e. the 'types-*' packages from PyPI). Currently, the mypy pre-commit hook is set up to install ALL available typeshed stubs, which includes the Flask 1.x stubs, which are the wrong stubs for us .... I'm trying to figure out if I can just explicitly define all the types-* packages in pre-commit that we need for Superset ... stay tuned. |
|
superseded by #23965 |
|
Closing in favor of #23965, but happy to discuss further if needed. |
Flask 2.1 no longer seems to be receiving updates.
In order to keep receveiving critical Flask updates, the upper version
constraint for Flask should be raised to a compatible newer version.
I picked Flask 2.2 as the compatible version.
This only required addressing one single old Flask 2.0 deprecation
warning which is now a removed function in Flask 2.2