Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter values are not updating when dependencies are set #23566

Conversation

michael-s-molina
Copy link
Member

SUMMARY

#23400 fixed the following error:

When the search was conducted using the "Dynamically search all filter values" in FilterBar, the original options got lost and the Select component was selecting all values as a consequence.

The strategy used for the fix was to store an array of the initial data and always append it when updating the select options. This caused a unintended problem with filter dependencies because the initial data may not be present when the filter values are affected by other filters.

Another problem is that "Dynamically search all filter values" is used when the number of options available exceeds the 1000 threshold and the user needs to search for values that are not loaded on the client side. At this moment, the select is very similar to an async select and the Select All feature will have many challenges as you can see here.

This PR removes the initial data state to fix the dependencies bug and also disables Select All when "Dynamically search all filter values" is checked.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-03.at.14.28.24.mov
Screen.Recording.2023-04-03.at.14.22.15.mov

TESTING INSTRUCTIONS

Check the videos and referenced PRs for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina merged commit 3bc4960 into apache:master Apr 3, 2023
michael-s-molina added a commit to airbnb/superset-fork that referenced this pull request Apr 7, 2023
eschutho pushed a commit that referenced this pull request Jul 7, 2023
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants