Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore ts warnings from older typescript versions #23262

Merged
merged 2 commits into from
Mar 2, 2023
Merged

fix: ignore ts warnings from older typescript versions #23262

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45e2e3
ignore ts warnings from older typescript versions
eschutho Mar 2, 2023
4b5ec49
bump the version for npm release script
eschutho Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions superset-embedded-sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export async function embedDashboard({
});

iframe.src = `${supersetDomain}/embedded/${id}${dashboardConfig}${filterConfigUrlParams}`;
//@ts-ignore
mountPoint.replaceChildren(iframe);
log('placed the iframe')
});
Expand All @@ -173,6 +174,7 @@ export async function embedDashboard({

function unmount() {
log('unmounting');
//@ts-ignore
mountPoint.replaceChildren();
}

Expand Down