chore: Update pre-commit packages

.pre-commit-config.yaml

@@ -20,16 +20,17 @@ repos:
     hooks:
       - id: isort
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.941
+    rev: v1.0.1
     hooks:
       - id: mypy
+        args: [--check-untyped-defs]
         additional_dependencies: [types-all]
   - repo: https://github.com/peterdemin/pip-compile-multi
-    rev: v2.4.1
+    rev: v2.6.2
     hooks:
       - id: pip-compile-multi-verify
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v3.2.0
+    rev: v4.4.0
     hooks:
       - id: check-docstring-first
       - id: check-added-large-files
@@ -41,7 +42,7 @@ repos:
       - id: trailing-whitespace
         args: ["--markdown-linebreak-ext=md"]
   - repo: https://github.com/psf/black
-    rev: 22.3.0
+    rev: 23.1.0
     hooks:
       - id: black
         language_version: python3

RELEASING/changelog.py

@@ -138,7 +138,7 @@ def _get_pull_request_details(self, git_log: GitLog) -> Dict[str, Any]:
         title = pr_info.title if pr_info else git_log.message
         pr_type = re.match(SUPERSET_PULL_REQUEST_TYPES, title)
         if pr_type:
-            pr_type = pr_type.group().strip('"')
+            pr_type = pr_type.group().strip('"')  # type: ignore
 
         labels = (" | ").join([label.name for label in pr_info.labels])
         is_risky = self._is_risk_pull_request(pr_info.labels)

superset-frontend/packages/superset-ui-chart-controls/src/components/ColumnOption.tsx

@@ -59,11 +59,9 @@ export function ColumnOption({
       <Tooltip id="metric-name-tooltip" title={tooltipText}>
         <span
           className="option-label column-option-label"
-          css={(theme: SupersetTheme) =>
-            css`
-              margin-right: ${theme.gridUnit}px;
-            `
-          }
+          css={(theme: SupersetTheme) => css`
+            margin-right: ${theme.gridUnit}px;
+          `}
           ref={labelRef}
         >
           {getColumnLabelText(column)}

superset-frontend/packages/superset-ui-chart-controls/src/components/MetricOption.tsx

@@ -71,11 +71,9 @@ export function MetricOption({
   const label = (
     <span
       className="option-label metric-option-label"
-      css={(theme: SupersetTheme) =>
-        css`
-          margin-right: ${theme.gridUnit}px;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        margin-right: ${theme.gridUnit}px;
+      `}
       ref={labelRef}
     >
       {link}

superset-frontend/src/components/EmptyState/index.tsx

@@ -158,11 +158,9 @@ export const EmptyStateBig = ({
   <EmptyStateContainer className={className}>
     {image && <ImageContainer image={image} size={EmptyStateSize.Big} />}
     <TextContainer
-      css={(theme: SupersetTheme) =>
-        css`
-          max-width: ${theme.gridUnit * 150}px;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        max-width: ${theme.gridUnit * 150}px;
+      `}
     >
       <BigTitle>{title}</BigTitle>
       {description && <BigDescription>{description}</BigDescription>}
@@ -189,11 +187,9 @@ export const EmptyStateMedium = ({
   <EmptyStateContainer>
     {image && <ImageContainer image={image} size={EmptyStateSize.Medium} />}
     <TextContainer
-      css={(theme: SupersetTheme) =>
-        css`
-          max-width: ${theme.gridUnit * 100}px;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        max-width: ${theme.gridUnit * 100}px;
+      `}
     >
       <Title>{title}</Title>
       {description && <Description>{description}</Description>}
@@ -218,11 +214,9 @@ export const EmptyStateSmall = ({
   <EmptyStateContainer>
     {image && <ImageContainer image={image} size={EmptyStateSize.Small} />}
     <TextContainer
-      css={(theme: SupersetTheme) =>
-        css`
-          max-width: ${theme.gridUnit * 75}px;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        max-width: ${theme.gridUnit * 75}px;
+      `}
     >
       <Title>{title}</Title>
       {description && <SmallDescription>{description}</SmallDescription>}

superset-frontend/src/components/Table/cell-renderers/NullCell/index.tsx

@@ -23,11 +23,9 @@ import { NULL_DISPLAY } from 'src/constants';
 function NullCell() {
   return (
     <span
-      css={(theme: SupersetTheme) =>
-        css`
-          color: ${theme.colors.grayscale.light1};
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        color: ${theme.colors.grayscale.light1};
+      `}
     >
       {NULL_DISPLAY}
     </span>

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx

@@ -226,13 +226,11 @@ const FilterControls: FC<FilterControlsProps> = ({
 
   const renderHorizontalContent = () => (
     <div
-      css={(theme: SupersetTheme) =>
-        css`
-          padding: 0 ${theme.gridUnit * 4}px;
-          min-width: 0;
-          flex: 1;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        padding: 0 ${theme.gridUnit * 4}px;
+        min-width: 0;
+        flex: 1;
+      `}
     >
       <DropdownContainer
         items={items}

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FiltersDropdownContent/index.tsx

@@ -47,12 +47,10 @@ export const FiltersDropdownContent = ({
   forceRenderOutOfScope,
 }: FiltersDropdownContentProps) => (
   <div
-    css={(theme: SupersetTheme) =>
-      css`
-        width: ${theme.gridUnit * 56}px;
-        padding: ${theme.gridUnit}px 0;
-      `
-    }
+    css={(theme: SupersetTheme) => css`
+      width: ${theme.gridUnit * 56}px;
+      padding: ${theme.gridUnit}px 0;
+    `}
   >
     {overflowedCrossFilters.map(crossFilter =>
       rendererCrossFilter(

superset-frontend/src/dashboard/components/nativeFilters/FilterCard/NameRow.tsx

@@ -44,20 +44,16 @@ export const NameRow = ({
 
   return (
     <Row
-      css={(theme: SupersetTheme) =>
-        css`
-          margin-bottom: ${theme.gridUnit * 3}px;
-          justify-content: space-between;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        margin-bottom: ${theme.gridUnit * 3}px;
+        justify-content: space-between;
+      `}
     >
       <InternalRow>
         <Icons.FilterSmall
-          css={(theme: SupersetTheme) =>
-            css`
-              margin-right: ${theme.gridUnit}px;
-            `
-          }
+          css={(theme: SupersetTheme) => css`
+            margin-right: ${theme.gridUnit}px;
+          `}
         />
         <TooltipWithTruncation title={elementsTruncated ? filter.name : null}>
           <FilterName ref={filterNameRef}>{filter.name}</FilterName>

superset-frontend/src/explore/components/ControlHeader.tsx

@@ -134,12 +134,10 @@ const ControlHeader: FC<ControlHeaderProps> = ({
     <div className="ControlHeader" data-test={`${name}-header`}>
       <div className="pull-left">
         <FormLabel
-          css={(theme: SupersetTheme) =>
-            css`
-              margin-bottom: ${theme.gridUnit * 0.5}px;
-              position: relative;
-            `
-          }
+          css={(theme: SupersetTheme) => css`
+            margin-bottom: ${theme.gridUnit * 0.5}px;
+            position: relative;
+          `}
         >
           {leftNode && <span>{leftNode}</span>}
           <span

superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx

@@ -56,11 +56,9 @@ function VizSupportValidation({ vizType }: { vizType: string }) {
   return (
     <div
       className="text-danger"
-      css={(theme: SupersetTheme) =>
-        css`
-          margin-top: ${theme.gridUnit}px;
-        `
-      }
+      css={(theme: SupersetTheme) => css`
+        margin-top: ${theme.gridUnit}px;
+      `}
     >
       <i className="fa fa-exclamation-circle text-danger" />{' '}
       <small>{t('This visualization type is not supported.')}</small>
@@ -114,15 +112,13 @@ const VizTypeControl = ({
         {initialValue && <VizSupportValidation vizType={initialValue} />}
       </div>
       <div
-        css={(theme: SupersetTheme) =>
-          css`
-            display: flex;
-            justify-content: flex-end;
-            margin-top: ${theme.gridUnit * 3}px;
-            color: ${theme.colors.grayscale.base};
-            text-decoration: underline;
-          `
-        }
+        css={(theme: SupersetTheme) => css`
+          display: flex;
+          justify-content: flex-end;
+          margin-top: ${theme.gridUnit * 3}px;
+          color: ${theme.colors.grayscale.base};
+          text-decoration: underline;
+        `}
       >
         <span role="button" tabIndex={0} onClick={openModal}>
           {t('View all charts')}

superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx

@@ -371,10 +371,9 @@ const timezoneHeaderStyle = (theme: SupersetTheme) => css`
   margin: ${theme.gridUnit * 3}px 0;
 `;
 
-const inputSpacer = (theme: SupersetTheme) =>
-  css`
-    margin-right: ${theme.gridUnit * 3}px;
-  `;
+const inputSpacer = (theme: SupersetTheme) => css`
+  margin-right: ${theme.gridUnit * 3}px;
+`;
 
 type NotificationAddStatus = 'active' | 'disabled' | 'hidden';
 

superset-frontend/src/views/components/Menu.tsx

@@ -59,9 +59,10 @@ const StyledHeader = styled.header`
         justify-content: center;
         /* must be exactly the height of the Antd navbar */
         min-height: 50px;
-        padding: ${theme.gridUnit}px ${theme.gridUnit * 2}px ${
-    theme.gridUnit
-  }px ${theme.gridUnit * 4}px;
+        padding: ${theme.gridUnit}px
+          ${theme.gridUnit * 2}px
+          ${theme.gridUnit}px
+          ${theme.gridUnit * 4}px;
         max-width: ${theme.gridUnit * theme.brandIconMaxWidth}px;
         img {
           height: 100%;

superset-frontend/src/visualizations/TimeTable/transformProps.ts

@@ -55,11 +55,13 @@ export default function transformProps(chartProps: TableChartProps) {
       typeof column === 'object' ? column : { label: column },
     );
   } else {
+    /* eslint-disable */
     const metricMap = datasource.metrics.reduce((acc, current) => {
       const map = acc;
       map[current.metric_name] = current;
       return map;
     }, {} as Record<string, Metric>);
+    /* eslint-disable */
     rows = metrics.map(metric =>
       typeof metric === 'object' ? metric : metricMap[metric],
     );

superset/charts/commands/export.py

@@ -38,7 +38,6 @@
 
 
 class ExportChartsCommand(ExportModelsCommand):
-
     dao = ChartDAO
     not_found = ChartNotFoundError
 

superset/charts/schemas.py

@@ -841,7 +841,6 @@ class ChartDataFilterSchema(Schema):
 
 
 class ChartDataExtrasSchema(Schema):
-
     relative_start = fields.String(
         description="Start time for relative time deltas. "
         'Default: `config["DEFAULT_RELATIVE_START_TIME"]`',

superset/cli/test.py

@@ -45,7 +45,6 @@ def load_test_users_run() -> None:
     Syncs permissions for those users/roles
     """
     if app.config["TESTING"]:
-
         sm = security_manager
 
         examples_db = database_utils.get_example_database()

superset/commands/export/assets.py

@@ -37,7 +37,6 @@ class ExportAssetsCommand(BaseCommand):
     """
 
     def run(self) -> Iterator[Tuple[str, str]]:
-
         metadata = {
             "version": EXPORT_VERSION,
             "type": "assets",

superset/commands/export/models.py

@@ -30,7 +30,6 @@
 
 
 class ExportModelsCommand(BaseCommand):
-
     dao: Type[BaseDAO] = BaseDAO
     not_found: Type[CommandException] = CommandException
 

superset/common/query_object.py

@@ -403,11 +403,9 @@ def cache_key(self, **extra: Any) -> str:
             and hasattr(self.datasource, "database")
             and self.datasource.database.impersonate_user
         ):
-
             if key := self.datasource.database.db_engine_spec.get_impersonation_key(
                 getattr(g, "user", None)
             ):
-
                 logger.debug(
                     "Adding impersonation key to QueryObject cache dict: %s", key
                 )

superset/config.py

@@ -1204,6 +1204,7 @@ def SQL_QUERY_MUTATOR(  # pylint: disable=invalid-name,unused-argument
 # functionality for both the SQL_Lab and Charts.
 MUTATE_AFTER_SPLIT = False
 
+
 # This allows for a user to add header data to any outgoing emails. For example,
 # if you need to include metadata in the header or you want to change the specifications
 # of the email title, header, or sender.

superset/dashboards/commands/export.py

@@ -102,7 +102,6 @@ def append_charts(position: Dict[str, Any], charts: Set[Slice]) -> Dict[str, Any
 
 
 class ExportDashboardsCommand(ExportModelsCommand):
-
     dao = DashboardDAO
     not_found = DashboardNotFoundError
 

superset/databases/api.py

@@ -1308,12 +1308,10 @@ def available(self) -> Response:
                 and hasattr(engine_spec, "sqlalchemy_uri_placeholder")
                 and getattr(engine_spec, "default_driver") in drivers
             ):
-                payload[
-                    "parameters"
-                ] = engine_spec.parameters_json_schema()  # type: ignore
+                payload["parameters"] = engine_spec.parameters_json_schema()
                 payload[
                     "sqlalchemy_uri_placeholder"
-                ] = engine_spec.sqlalchemy_uri_placeholder  # type: ignore
+                ] = engine_spec.sqlalchemy_uri_placeholder
 
             available_databases.append(payload)
 

superset/databases/commands/export.py

@@ -51,7 +51,6 @@ def parse_extra(extra_payload: str) -> Dict[str, Any]:
 
 
 class ExportDatabasesCommand(ExportModelsCommand):
-
     dao = DatabaseDAO
     not_found = DatabaseNotFoundError
 

superset/databases/commands/test_connection.py

@@ -200,7 +200,6 @@ def ping(engine: Engine) -> bool:
             )
             raise DatabaseSecurityUnsafeError(message=str(ex)) from ex
         except SupersetTimeoutException as ex:
-
             event_logger.log_with_context(
                 action=get_log_connection_action(
                     "test_connection_error", ssh_tunnel, ex