Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dataset import error message #23025

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: dataset import error message #23025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions superset/commands/importers/v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def run(self) -> None:
try:
self._import(db.session, self._configs, self.overwrite)
db.session.commit()
except CommandException as ex:
db.session.rollback()
raise ex
except Exception as ex:
db.session.rollback()
raise self.import_error() from ex
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from ex will raise the generic dataset import error with the ex message on the __cause__ attr. This cause will not be included on the API error message response.

Expand Down
2 changes: 1 addition & 1 deletion superset/datasets/commands/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,5 +193,5 @@ class DatasetDuplicateFailedError(CreateFailedError):
message = _("Dataset could not be duplicated.")


class DatasetForbiddenDataURI(ForbiddenError):
class DatasetForbiddenDataURI(ImportFailedError):
message = _("Data URI is not allowed.")