Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs in Sankey diagrams #2290

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Fixing bugs in Sankey diagrams #2290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixing bugs in Sankey diagrams 
* NULL values for name breaks the chart
* negative rect svg height values
  • Loading branch information
@mistercrunch
mistercrunch committed Feb 27, 2017
commit ab9d947e6ec999ff4408a54683c8bd665181c6a9
9 changes: 4 additions & 5 deletions superset/assets/visualizations/sankey.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,13 @@ function sankeyVis(slice, payload) {
})
.on('drag', dragmove)
);

const minRectHeight = 5;
node.append('rect')
.attr('height', function (d) {
return d.dy;
})
.attr('height', d => d.dy > minRectHeight ? d.dy : minRectHeight)
.attr('width', sankey.nodeWidth())
.style('fill', function (d) {
d.color = category21(d.name.replace(/ .*/, ''));
const name = d.name || 'N/A';
d.color = category21(name.replace(/ .*/, ''));
return d.color;
})
.style('stroke', function (d) {
Expand Down