-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssh-tunnel): update fields for open tunnel with private + private key passwords #22764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22764 +/- ##
=======================================
Coverage 67.25% 67.25%
=======================================
Files 1876 1876
Lines 71819 71819
Branches 7864 7864
=======================================
Hits 48299 48299
Misses 21494 21494
Partials 2026 2026
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
params["private_key"] = private_key | ||
params["private_key_password"] = ssh_tunnel.private_key_password | ||
params["ssh_pkey"] = private_key | ||
params["ssh_private_key_password"] = ssh_tunnel.private_key_password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I was reading the docs here: https://sshtunnel.readthedocs.io/en/latest/ thanks!
Also, not a blocker for these changes, but probably worth mentioning we should make sure that when updating a tunnel, if we send a password
or private_key/private_key_password
, we remove the other login method from the tunnel (the UI is doing it already), otherwise, it will get into the if
all the time if both are present, even if password
is not the latest login method of the tunnel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's cut a ticket for this as well on our end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
With the new extensions class, we forgot to update the params to match the
ssh_tunnel.open_tunnel
function.private_key
->ssh_pkey
ssh_private_key
->ssh_private_key_password
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION