-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjusting Alerts & reports docs to use the latest chromedriver #22517
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22517 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 1851 1851
Lines 70696 70696
Branches 7764 7764
=======================================
Hits 47299 47299
Misses 21375 21375
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think we should use pinned versions, WDYT?
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@villebro followed your suggestion... let me know if you think we're good here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SUMMARY
Small tweak to the docs, as suggested by someone that solved their issue after encountering an error based on an unsupported chromedriver version. Now the docs will suggest using the latest version, rather than the incompatible one.
Fixes #20843
Hat tip to @nigzak for the suggestion.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION