Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(translation): add missing Russian translation, add plural forms #22415

Merged
merged 9 commits into from
Jan 19, 2023

Conversation

artemonsh
Copy link
Contributor

@artemonsh artemonsh commented Dec 14, 2022

SUMMARY

This PR intends to improve russian translation.
The binary .mo file now can be successfully compiled as all errors were resolved, hence backend part is localized, too.
Plural Forms added as they were incorrect before.

Untranslated messages with msgstr "" dropped from 949 to 306.

BEFORE SCREENSHOT

image

AFTER SCREENSHOT

This is just one of the examples. A lot more translations are added/fixed.
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #22415 (d57ae0b) into master (80b3113) will decrease coverage by 0.13%.
The diff coverage is 33.33%.

❗ Current head d57ae0b differs from pull request most recent head 8aa57d4. Consider uploading reports for the commit 8aa57d4 to get more accurate results

@@            Coverage Diff             @@
##           master   #22415      +/-   ##
==========================================
- Coverage   67.11%   66.98%   -0.13%     
==========================================
  Files        1869     1876       +7     
  Lines       71612    71812     +200     
  Branches     7822     7863      +41     
==========================================
+ Hits        48059    48103      +44     
- Misses      21526    21683     +157     
+ Partials     2027     2026       -1     
Flag Coverage Δ
hive 52.60% <63.04%> (+0.01%) ⬆️
mysql ?
postgres 78.12% <93.47%> (+0.01%) ⬆️
presto 52.49% <63.04%> (+0.01%) ⬆️
python 81.33% <100.00%> (-0.02%) ⬇️
sqlite 76.50% <93.47%> (+0.02%) ⬆️
unit 51.54% <86.95%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/Sunburst/buildQuery.ts 0.00% <0.00%> (ø)
...plugins/plugin-chart-echarts/src/Sunburst/index.ts 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Sunburst/transformProps.ts 0.00% <0.00%> (ø)
...gins/plugin-chart-echarts/src/Treemap/constants.ts 54.54% <ø> (ø)
.../plugins/plugin-chart-echarts/src/Treemap/types.ts 100.00% <ø> (ø)
superset-frontend/src/GlobalStyles.tsx 0.00% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 63.56% <ø> (ø)
superset/constants.py 100.00% <ø> (ø)
superset-frontend/src/components/Modal/Modal.tsx 85.89% <25.00%> (-3.30%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@artemonsh artemonsh marked this pull request as draft January 9, 2023 13:57
@artemonsh artemonsh marked this pull request as ready for review January 16, 2023 09:33
@artemonsh artemonsh closed this Jan 17, 2023
@artemonsh artemonsh reopened this Jan 17, 2023
@artemonsh artemonsh closed this Jan 17, 2023
@artemonsh artemonsh reopened this Jan 17, 2023
@rusackas rusackas merged commit 5026da5 into apache:master Jan 19, 2023
@artemonsh artemonsh deleted the real_master branch January 19, 2023 06:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants