Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(welcome): make examples tab customizable #22302

Merged
merged 14 commits into from
Dec 21, 2022
Merged

feat(welcome): make examples tab customizable #22302

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7c68da1
feat(welcome): make examples tab customizable
villebro Dec 1, 2022
c607c89
add license
villebro Dec 1, 2022
c0f7a87
fix types
villebro Dec 1, 2022
d2a5d0f
more types
villebro Dec 1, 2022
e63231d
more fixing
villebro Dec 1, 2022
201e447
lots of refactoring
villebro Dec 15, 2022
1524efa
delint and add simple test
villebro Dec 15, 2022
1705ba8
console.log('🤦')
villebro Dec 15, 2022
0e9b54f
Merge branch 'master' into villebro/welcome
villebro Dec 16, 2022
e5c2975
simplify and fix case
villebro Dec 16, 2022
2910d40
fix chart is favorite filter
villebro Dec 16, 2022
d0fcc95
default to examples
villebro Dec 17, 2022
9f161d8
add tests
villebro Dec 18, 2022
f5160cf
remove admin as birth_names owner/creator
villebro Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
console.log('🤦')
  • Loading branch information
@villebro
villebro committed Dec 15, 2022
commit 1705ba845d27cc0ad407109b6009a87f7687d8e1
1 change: 0 additions & 1 deletion superset-frontend/src/views/CRUD/welcome/Welcome.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
} else setActiveChild(activeTab || 'Created');
} else if (!activeTab) setActiveChild('Created');
else setActiveChild(activeTab);
console.log('!!!', data);
setActivityData(activityData => ({ ...activityData, ...data }));
})
.catch(
Expand Down