-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove actions prop and refactor code in SQL Lab #22231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22231 +/- ##
==========================================
- Coverage 66.86% 66.85% -0.01%
==========================================
Files 1840 1840
Lines 70161 70193 +32
Branches 7657 7662 +5
==========================================
+ Hits 46910 46925 +15
- Misses 21281 21294 +13
- Partials 1970 1974 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pinged a couple committers for review, and might also ask for eyes from @codyml or @eric-briscoe if they have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me!
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.213.134.150:8080. Credentials are |
@michael-s-molina Can we merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Refactor all actions in sqlLab in order to use useDispatch() hook instead of actions prop in every child components.
Also fix type for Query
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION