Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing filtering issues #2223

Merged
merged 2 commits into from
Feb 22, 2017
Merged

Fixing filtering issues #2223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b0c24
Fixing filtering issues
mistercrunch Feb 22, 2017
2de2427
Fixing off by one error
mistercrunch Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing off by one error
  • Loading branch information
@mistercrunch
mistercrunch committed Feb 22, 2017
commit 2de24279a6187af9b6bdf66a3bcb8065cb41eaf5
2 changes: 1 addition & 1 deletion superset/assets/javascripts/explorev2/stores/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function getControlsState(state, form_data) {
// Removing invalid filters that point to a now inexisting column
if (control.type === 'FilterControl' && control.choices) {
const choiceValues = control.choices.map(c => c[0]);
formData[k] = formData[k].filter(flt => choiceValues.indexOf(flt.col) > 0);
formData[k] = formData[k].filter(flt => choiceValues.indexOf(flt.col) >= 0);
}

if (typeof control.default === 'function') {
Expand Down