Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reports): force data generation in csv reports #22196

Merged
merged 7 commits into from
Nov 26, 2022

Conversation

mayurnewase
Copy link
Contributor

@mayurnewase mayurnewase commented Nov 22, 2022

SUMMARY

fixes: #22189

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. create table chart
  2. setup csv report on that chart and enable Ignore cache when generating screenshot
  3. update data in datasource without bursting cache
  4. check csv in the report received, should contain new data

ADDITIONAL INFORMATION

  • Has associated issue: [reports] GET chart/<pk>/data api doesn't respect force parameter #22189
  • Required feature flags: ALERTS_REPORTS
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@mayurnewase mayurnewase marked this pull request as ready for review November 22, 2022 11:04
@mayurnewase mayurnewase changed the title fix: force data generation in csv reports fix(reports): force data generation in csv reports Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #22196 (e8802b9) into master (6f2e76b) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22196      +/-   ##
==========================================
- Coverage   66.89%   66.85%   -0.05%     
==========================================
  Files        1805     1809       +4     
  Lines       69071    69119      +48     
  Branches     7369     7369              
==========================================
  Hits        46208    46208              
- Misses      20956    21004      +48     
  Partials     1907     1907              
Flag Coverage Δ
hive 52.57% <100.00%> (-0.35%) ⬇️
mysql 78.08% <100.00%> (-0.17%) ⬇️
postgres 78.15% <100.00%> (-0.17%) ⬇️
presto 52.47% <100.00%> (-0.35%) ⬇️
python 81.34% <100.00%> (-0.12%) ⬇️
sqlite 76.60% <100.00%> (-0.20%) ⬇️
unit 50.86% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/schemas.py 99.35% <ø> (+<0.01%) ⬆️
superset/charts/data/api.py 89.87% <100.00%> (+0.06%) ⬆️
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tables/models.py 44.15% <0.00%> (-23.38%) ⬇️
superset/reports/notifications/slack.py 79.51% <0.00%> (-8.49%) ⬇️
superset/databases/commands/create.py 86.79% <0.00%> (-5.05%) ⬇️
superset/utils/urls.py 97.22% <0.00%> (-2.78%) ⬇️
superset/databases/api.py 93.53% <0.00%> (-1.99%) ⬇️
superset/explore/commands/get.py 88.77% <0.00%> (-1.76%) ⬇️
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mayurnewase
Copy link
Contributor Author

Should we also change Ignore cache when generating screenshot to Ignore cache when generating report as CSV, json do not need screenshots.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! LGTM.

@mayurnewase
Copy link
Contributor Author

Thanks for the reviews 😀

@zhaoyongjie zhaoyongjie merged commit a8bc53d into apache:master Nov 26, 2022
michael-s-molina pushed a commit that referenced this pull request Jan 5, 2023
@mistercrunch mistercrunch added 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.5 v2.0.1 🍒 1.5.3 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[reports] GET chart/<pk>/data api doesn't respect force parameter
3 participants