Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Most common flaky Cypress tests #21941

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix: Most common flaky Cypress tests #21941

merged 2 commits into from
Oct 27, 2022

Conversation

geido
Copy link
Member

@geido geido commented Oct 26, 2022

SUMMARY

This PR attempts to fix some of the most common flaky Cypress tests

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido added the need:qa-review Requires QA review label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #21941 (098279d) into master (fa67315) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21941      +/-   ##
==========================================
- Coverage   66.95%   66.78%   -0.17%     
==========================================
  Files        1807     1807              
  Lines       69182    69185       +3     
  Branches     7402     7402              
==========================================
- Hits        46319    46208     -111     
- Misses      20952    21066     +114     
  Partials     1911     1911              
Flag Coverage Δ
hive ?
javascript 53.39% <ø> (+<0.01%) ⬆️
mysql 78.37% <ø> (ø)
postgres 78.43% <ø> (ø)
presto ?
python 81.15% <ø> (-0.35%) ⬇️
sqlite 76.92% <ø> (ø)
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.14% <0.00%> (-16.21%) ⬇️
superset/db_engine_specs/presto.py 81.05% <0.00%> (-6.73%) ⬇️
superset/models/sql_lab.py 72.83% <0.00%> (-1.97%) ⬇️
superset/connectors/sqla/models.py 90.31% <0.00%> (-0.70%) ⬇️
superset/db_engine_specs/base.py 89.38% <0.00%> (-0.32%) ⬇️
superset/models/core.py 89.88% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 90.21% <0.00%> (-0.11%) ⬇️
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 7e3e133 into master Oct 27, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/cypress-flaky branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants