-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disables HTML rendering in Toast by default #21853
feat: Disables HTML rendering in Toast by default #21853
Conversation
f247d25
to
009fc23
Compare
Reviewers, please let me know if we actually have an instance where we use HTML in toast messages already. I couldn’t find one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I'm not aware of any toast with html content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I did a quick scour through the code and it doesn't look like we have any existing toasts with HTML, I think this should be safe to implement 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #21853 +/- ##
==========================================
- Coverage 66.93% 66.92% -0.01%
==========================================
Files 1805 1805
Lines 69066 69070 +4
Branches 7369 7373 +4
==========================================
+ Hits 46227 46228 +1
- Misses 20932 20936 +4
+ Partials 1907 1906 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
(cherry picked from commit 47b1e0c)
(cherry picked from commit 47b1e0c)
(cherry picked from commit 47b1e0c)
(cherry picked from commit 47b1e0c)
(cherry picked from commit 47b1e0c)
SUMMARY
This PR disables HTML rendering in toast messages by default. I couldn't find any instances of toast messages with HTML content but it is a valid use case, so I created an
allowHtml
property for this scenario.TESTING INSTRUCTIONS
1 - Make sure toast messages don't render HTML by default
2 - Make sure toast messages render HTML if
allowHtml
is enabledADDITIONAL INFORMATION