-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dataset left panel now uses client side search #21770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21770 +/- ##
=========================================
Coverage 66.82% 66.82%
=========================================
Files 1797 1802 +5
Lines 68752 71346 +2594
Branches 7325 8176 +851
=========================================
+ Hits 45943 47678 +1735
- Misses 20935 21653 +718
- Partials 1874 2015 +141
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@pkdotson Ephemeral environment spinning up at http://54.70.240.166:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually tested and code looks good. Thanks for the test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR changed the left panel's search functionality from server side searching to client side searching.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
http://localhost:9000/dataset/add/?testing
ADDITIONAL INFORMATION