-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mulitple temporal filters in AdhocFilter and move the Time Section away #21767
Merged
zhaoyongjie
merged 30 commits into
apache:master
from
zhaoyongjie:feat/time_column_in_filters
Nov 2, 2022
Merged
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
2be5fe5
feat: support mulitple datetime filter in AdhocFilter and move away t…
zhaoyongjie 7a66d4c
should pass all CI steps
zhaoyongjie e852a70
add UT for time_range_utils
zhaoyongjie 1950f63
fix time offset
zhaoyongjie 8508eaf
fix pylint
zhaoyongjie 2afa513
datetime_between => temporal_between
zhaoyongjie 26b27c7
add more UT
zhaoyongjie 602f975
fix mysql failure UT
zhaoyongjie cdb1774
new style in date picker
zhaoyongjie 2cda470
datepicker modal in adhoc filter
zhaoyongjie 1a0bf44
fix overlap in modal
zhaoyongjie 4ba7b8b
fix evalResponse first open modal
zhaoyongjie 950d468
add header
zhaoyongjie 3a3e0cc
apply global default time filter
zhaoyongjie 76199d0
temporal_between => temporal_range
zhaoyongjie d501d49
code smell
zhaoyongjie c54f24f
fix drag&drop and save temporal column
zhaoyongjie 43b702f
fix subject change
zhaoyongjie e8a7d34
fix adhoc filter title
zhaoyongjie fbbe603
use isTemporalColumn
zhaoyongjie f76053c
add ut
zhaoyongjie 3196eed
fix previous UT
zhaoyongjie 7767870
fix ut
zhaoyongjie cbc1be3
support Handlebars
zhaoyongjie 8a48fd0
ut for time filter
zhaoyongjie 905c60e
addressing comments
zhaoyongjie 958c5da
fix lint
zhaoyongjie 207f9b8
fix ut
zhaoyongjie a10d259
fix label error when custom SQL => simple panel
zhaoyongjie 059fb2f
ut for useDatePickerInAdhocfilter
zhaoyongjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slightly unrelated - it would be nice to have an ESLint rule for this to make the JS/TS code more consistent