fix: Duplicated numeric values in Select #21480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21480 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 1791 1791
Lines 68459 68459
Branches 7268 7268
=======================================
Hits 45643 45643
Misses 20955 20955
Partials 1861 1861
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.245.190.12:8080. Credentials are |
geido
approved these changes
Sep 16, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mayurnewase
added a commit
to mayurnewase/incubator-superset
that referenced
this pull request
Sep 22, 2022
This reverts commit b739e27.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When
allowNewOptionswas true and the options contained numbers as values, if the user searched for a value that already existed, the options would be duplicated becausehasOptionwas not transforming thestringinput before comparing it with the existing values. Given that the possible value types arestring | number | null | undefined, this PR changes that logic to use the equality operator (not strict) to compare the values.@cccs-RyanK
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before.mov
Screen.Recording.2022-09-13.at.3.20.22.PM.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION