Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix act errors in FaveStar test #21360

Merged
merged 2 commits into from
Sep 8, 2022
Merged

test: Fix act errors in FaveStar test #21360

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb4f437
3 act errors removed from FaveStar test
lyndsiWilliams Sep 7, 2022
4915ca3
Change it to test
lyndsiWilliams Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions superset-frontend/src/components/FaveStar/FaveStar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ jest.mock('src/components/Tooltip', () => ({
Tooltip: (props: any) => <div data-test="tooltip" {...props} />,
}));

test('render right content', () => {
it('render right content', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('render right content', async () => {
test('render right content', async () => {

const props = {
itemId: 3,
saveFaveStar: jest.fn(),
};

const { rerender } = render(<FaveStar {...props} isStarred />);
const { rerender, findByRole } = render(<FaveStar {...props} isStarred />);
expect(screen.getByRole('button')).toBeInTheDocument();
expect(
screen.getByRole('img', { name: 'favorite-selected' }),
Expand All @@ -45,7 +45,7 @@ test('render right content', () => {

rerender(<FaveStar {...props} />);
expect(
screen.getByRole('img', { name: 'favorite-unselected' }),
await findByRole('img', { name: 'favorite-unselected' }),
).toBeInTheDocument();

expect(props.saveFaveStar).toBeCalledTimes(1);
Expand All @@ -54,7 +54,7 @@ test('render right content', () => {
expect(props.saveFaveStar).toBeCalledWith(props.itemId, false);
});

test('render content on tooltip', () => {
it('render content on tooltip', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('render content on tooltip', async () => {
test('render content on tooltip', async () => {

const props = {
itemId: 3,
showTooltip: true,
Expand All @@ -63,7 +63,7 @@ test('render content on tooltip', () => {

render(<FaveStar {...props} />);

expect(screen.getByTestId('tooltip')).toBeInTheDocument();
expect(await screen.findByTestId('tooltip')).toBeInTheDocument();
expect(screen.getByTestId('tooltip')).toHaveAttribute(
'id',
'fave-unfave-tooltip',
Expand All @@ -75,7 +75,7 @@ test('render content on tooltip', () => {
expect(screen.getByRole('button')).toBeInTheDocument();
});

test('Call fetchFaveStar only on the first render', () => {
it('Call fetchFaveStar only on the first render', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('Call fetchFaveStar only on the first render', async () => {
test('Call fetchFaveStar only on the first render', async () => {

const props = {
itemId: 3,
fetchFaveStar: jest.fn(),
Expand All @@ -84,7 +84,10 @@ test('Call fetchFaveStar only on the first render', () => {
showTooltip: false,
};

const { rerender } = render(<FaveStar {...props} />);
const { rerender, findByRole } = render(<FaveStar {...props} />);
expect(
await findByRole('img', { name: 'favorite-unselected' }),
).toBeInTheDocument();
expect(props.fetchFaveStar).toBeCalledTimes(1);
expect(props.fetchFaveStar).toBeCalledWith(props.itemId);

Expand Down