Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Copy link doesn't apply the unsaved changes #21311

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the 'COPY LINK' feature in SQLLAB that only copies previous one.
This is caused by missing unsaved changes on ShareSqlLabQuery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • Go to SqlLab
  • make changes on editor
  • "Copy Link" and then go to the link
  • Check the updates

ADDITIONAL INFORMATION

  • Has associated issue: perf(sqllab): Rendering perf improvement using immutable state #20877
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cc: @ktmud @hughhhh

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #21311 (e1e3c74) into master (222f1e7) will increase coverage by 0.02%.
The diff coverage is 67.30%.

❗ Current head e1e3c74 differs from pull request most recent head c8eea26. Consider uploading reports for the commit c8eea26 to get more accurate results

@@            Coverage Diff             @@
##           master   #21311      +/-   ##
==========================================
+ Coverage   66.43%   66.45%   +0.02%     
==========================================
  Files        1788     1789       +1     
  Lines       68276    68299      +23     
  Branches     7271     7276       +5     
==========================================
+ Hits        45358    45390      +32     
+ Misses      21045    21034      -11     
- Partials     1873     1875       +2     
Flag Coverage Δ
javascript 52.50% <87.17%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 54.23% <ø> (ø)
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <ø> (ø)
...perset/utils/pandas_postprocessing/contribution.py 100.00% <ø> (ø)
superset/utils/network.py 34.37% <7.69%> (-3.56%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 75.24% <50.00%> (+0.24%) ⬆️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.41% <77.77%> (+0.82%) ⬆️
...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx 82.75% <83.33%> (+1.98%) ⬆️
...frontend/src/components/ResizableSidebar/index.tsx 83.33% <83.33%> (ø)
superset-frontend/src/SqlLab/constants.ts 100.00% <100.00%> (ø)
...mponents/ResizableSidebar/useStoredSidebarWidth.ts 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ktmud ktmud merged commit acd9515 into apache:master Sep 6, 2022
justinpark added a commit to airbnb/superset-fork that referenced this pull request Sep 8, 2022
justinpark added a commit to airbnb/superset-fork that referenced this pull request Sep 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants