-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Typing of labelMap #21181
fix: Typing of labelMap #21181
Conversation
Storybook has completed and can be viewed at |
Codecov Report
@@ Coverage Diff @@
## master #21181 +/- ##
==========================================
- Coverage 66.40% 66.39% -0.01%
==========================================
Files 1781 1781
Lines 67874 67893 +19
Branches 7239 7248 +9
==========================================
+ Hits 45069 45077 +8
- Misses 20946 20954 +8
- Partials 1859 1862 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@michael-s-molina the types here and here also needs to be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Storybook has completed and can be viewed at |
SUMMARY
Fixes the typing of
labelMap
to usestring
instead ofDataRecordValue
as values.ADDITIONAL INFORMATION