Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply Time Grain to X-Axis column #21163

Merged
merged 27 commits into from
Sep 7, 2022
Merged

feat: apply Time Grain to X-Axis column #21163

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
49fa61b
feat: time grain into column
zhaoyongjie Aug 23, 2022
11e6c9f
fix test case
zhaoyongjie Aug 24, 2022
d7039ef
fix ut
zhaoyongjie Aug 24, 2022
0bd97db
fix sqlite
zhaoyongjie Aug 24, 2022
045bbf1
support the original column
zhaoyongjie Aug 24, 2022
36c7087
categorical column
zhaoyongjie Aug 24, 2022
db0b8fb
quotes in MySQL
zhaoyongjie Aug 25, 2022
353620e
probe adhoc column type
zhaoyongjie Aug 25, 2022
3d22933
quoter
zhaoyongjie Aug 26, 2022
3c2e88d
add ut
zhaoyongjie Aug 26, 2022
23de307
add frontend
zhaoyongjie Aug 31, 2022
1854212
typos
zhaoyongjie Aug 31, 2022
0110bd2
move control
zhaoyongjie Aug 31, 2022
8e8f179
time grain visibility
zhaoyongjie Aug 31, 2022
800f8b9
:= operator
zhaoyongjie Aug 31, 2022
01411fd
fix pylint
zhaoyongjie Aug 31, 2022
eeba0bf
fix coverage
zhaoyongjie Sep 1, 2022
c9a9651
apply time_grain only in echarts
zhaoyongjie Sep 1, 2022
37ac13e
show time grain when get undefined
zhaoyongjie Sep 1, 2022
2322afc
addressing comments
zhaoyongjie Sep 2, 2022
b7ad0e3
remove unused condition
zhaoyongjie Sep 2, 2022
ec873f2
addressing comments
zhaoyongjie Sep 2, 2022
6538da5
use local variable
zhaoyongjie Sep 2, 2022
1512c0b
variables
zhaoyongjie Sep 2, 2022
d450d2d
rename
zhaoyongjie Sep 2, 2022
dfe8b13
add updateing line
zhaoyongjie Sep 2, 2022
f6d31b3
typo
zhaoyongjie Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@zhaoyongjie
zhaoyongjie committed Sep 2, 2022
commit d450d2d6397af27aec45ba97975d51d01b4e6cdd
2 changes: 1 addition & 1 deletion superset/utils/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,7 @@ def is_adhoc_column(column: Column) -> TypeGuard[AdhocColumn]:
return isinstance(column, dict)


def get_axis_column(columns: Optional[List[Column]]) -> Optional[AdhocColumn]:
def get_base_axis_column(columns: Optional[List[Column]]) -> Optional[AdhocColumn]:
if columns is None:
return None
axis_cols = [
Expand Down