Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): tracking url and error alert padding #20937

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix(sqllab): tracking url and error alert padding #20937

merged 1 commit into from
Aug 2, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Aug 1, 2022

SUMMARY

Add back the missing space between tracking url button and alert messages when SQL Lab query results failed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Xnip2022-08-01_10-07-06

After

Xnip2022-08-01_10-08-38

TESTING INSTRUCTIONS

Run a failed query in Presto

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

justinpark
justinpark approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ktmud ktmud merged commit ac58582 into apache:master Aug 2, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 8, 2022
@ktmud @jinghua-qa
fix(sqllab): tracking url and error alert padding (apache#20937)
f32e5d5 
(cherry picked from commit ac58582)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@justinpark justinpark justinpark approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/S 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ktmud @justinpark @john-bodley @mistercrunch @jinghua-qa