Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger message #20714

Merged
merged 1 commit into from
Jul 15, 2022
Merged

fix: logger message #20714

merged 1 commit into from
Jul 15, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Small fix: when we try to load a DB engine spec but it fails (because of missing dependencies, for example) the logging message will also fail because engine_spec is undefined.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #20714 (ea9abad) into master (2cb4fd3) will decrease coverage by 11.63%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master   #20714       +/-   ##
===========================================
- Coverage   66.82%   55.19%   -11.64%     
===========================================
  Files        1750     1750               
  Lines       65896    65896               
  Branches     7017     7017               
===========================================
- Hits        44035    36370     -7665     
- Misses      20075    27740     +7665     
  Partials     1786     1786               
Flag Coverage Δ
hive 53.87% <0.00%> (ø)
postgres ?
presto 53.73% <0.00%> (ø)
python 58.71% <0.00%> (-24.25%) ⬇️
sqlite ?
unit 51.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/__init__.py 84.61% <0.00%> (ø)
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.30% <0.00%> (-68.68%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/reports/commands/execute.py 24.45% <0.00%> (-67.16%) ⬇️
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb4fd3...ea9abad. Read the comment docs.

@michael-s-molina
Copy link
Member

@betodealmeida The license error was fixed here so you just need to rebase your PR.

@betodealmeida betodealmeida merged commit c70d102 into apache:master Jul 15, 2022
eschutho pushed a commit that referenced this pull request Sep 20, 2022
(cherry picked from commit c70d102)
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
(cherry picked from commit c70d102)
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants