Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve & un-skip flaky Cypress test #20568

Merged
merged 1 commit into from
Jun 30, 2022
Merged

test: Improve & un-skip flaky Cypress test #20568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Try making skipped Cypress test less flaky and un-skip.
  • Loading branch information
@codyml
codyml committed Jun 30, 2022
commit 41792d9709e38f8f09e5d49b4f934701b3f02596
14 changes: 10 additions & 4 deletions superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,16 @@ describe('Test datatable', () => {
cy.get('[data-test="row-count-label"]').contains('26 rows');
cy.get('.ant-empty-description').should('not.exist');
});
it.skip('Datapane loads view samples', () => {
cy.contains('Samples').click();
cy.get('[data-test="row-count-label"]').contains('1k rows');
cy.get('.ant-empty-description').should('not.exist');
it('Datapane loads view samples', () => {
cy.intercept('/api/v1/dataset/*/samples?force=false').as('Samples');
cy.contains('Samples')
.click()
.then(() => {
cy.wait('@Samples');
cy.get('.ant-tabs-tab-active').contains('Samples');
cy.get('[data-test="row-count-label"]').contains('1k rows');
cy.get('.ant-empty-description').should('not.exist');
});
});
});

Expand Down