Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump FAB to 4.1.2 #20483

Merged
merged 2 commits into from
Jun 24, 2022
Merged

fix: bump FAB to 4.1.2 #20483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56fa0c
fix: bump FAB to 4.1.2
dpgaspar Jun 23, 2022
d79ad4d
Merge branch 'master' into fix/bum-fab-4.1.2
dpgaspar Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ flask==2.0.3
# flask-migrate
# flask-sqlalchemy
# flask-wtf
flask-appbuilder==4.0.0
flask-appbuilder==4.1.2
# via apache-superset
flask-babel==1.0.0
# via flask-appbuilder
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def get_git_sha() -> str:
"cryptography>=3.3.2",
"deprecation>=2.1.0, <2.2.0",
"flask>=2.0.0, <3.0.0",
"flask-appbuilder>=4.0.0, <5.0.0",
"flask-appbuilder>=4.1.2, <5.0.0",
"flask-caching>=1.10.0",
"flask-compress",
"flask-talisman",
Expand Down
12 changes: 9 additions & 3 deletions superset/connectors/sqla/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ class SelectDataRequired(DataRequired): # pylint: disable=too-few-public-method
field_flags = ()


class TableColumnInlineView(CompactCRUDMixin, SupersetModelView):
class TableColumnInlineView(
CompactCRUDMixin, SupersetModelView
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(models.TableColumn)
# TODO TODO, review need for this on related_views
class_permission_name = "Dataset"
Expand Down Expand Up @@ -192,7 +194,9 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView):
edit_form_extra_fields = add_form_extra_fields


class SqlMetricInlineView(CompactCRUDMixin, SupersetModelView):
class SqlMetricInlineView(
CompactCRUDMixin, SupersetModelView
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(models.SqlMetric)
class_permission_name = "Dataset"
method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP
Expand Down Expand Up @@ -274,7 +278,9 @@ def __init__(self, **kwargs: Any):
super().__init__(**kwargs)


class RowLevelSecurityFiltersModelView(SupersetModelView, DeleteMixin):
class RowLevelSecurityFiltersModelView(
SupersetModelView, DeleteMixin
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(models.RowLevelSecurityFilter)

list_widget = cast(SupersetListWidget, RowLevelSecurityListWidget)
Expand Down
4 changes: 3 additions & 1 deletion superset/views/access_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
from superset.views.core import DAR


class AccessRequestsModelView(SupersetModelView, DeleteMixin):
class AccessRequestsModelView(
SupersetModelView, DeleteMixin
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(DAR)
include_route_methods = RouteMethod.CRUD_SET
list_columns = [
Expand Down
4 changes: 3 additions & 1 deletion superset/views/annotations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ def __call__(self, form: Dict[str, Any], field: Any) -> None:
)


class AnnotationModelView(SupersetModelView, CompactCRUDMixin):
class AnnotationModelView(
SupersetModelView, CompactCRUDMixin
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(Annotation)
include_route_methods = RouteMethod.CRUD_SET | {"annotation"}

Expand Down
4 changes: 3 additions & 1 deletion superset/views/css_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
from superset.views.base import DeleteMixin, SupersetModelView


class CssTemplateModelView(SupersetModelView, DeleteMixin):
class CssTemplateModelView(
SupersetModelView, DeleteMixin
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(models.CssTemplate)
include_route_methods = RouteMethod.CRUD_SET

Expand Down
2 changes: 1 addition & 1 deletion superset/views/log/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from . import LogMixin


class LogModelView(LogMixin, SupersetModelView):
class LogModelView(LogMixin, SupersetModelView): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(models.Log)
include_route_methods = {RouteMethod.LIST, RouteMethod.SHOW}
class_permission_name = "Log"
Expand Down
4 changes: 3 additions & 1 deletion superset/views/sql_lab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@
logger = logging.getLogger(__name__)


class SavedQueryView(SupersetModelView, DeleteMixin):
class SavedQueryView(
SupersetModelView, DeleteMixin
): # pylint: disable=too-many-ancestors
datamodel = SQLAInterface(SavedQuery)
include_route_methods = RouteMethod.CRUD_SET

Expand Down