-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: async queries limit bug #20468
fix: async queries limit bug #20468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, Arash!
a771148
to
ae626e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #20468 +/- ##
===========================================
- Coverage 66.72% 54.91% -11.82%
===========================================
Files 1739 1739
Lines 65130 65611 +481
Branches 6898 6898
===========================================
- Hits 43459 36028 -7431
- Misses 19921 27833 +7912
Partials 1750 1750
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ae626e7
to
e4d02f8
Compare
e4d02f8
to
a8b29d2
Compare
(cherry picked from commit 2c16be4)
🏷️ preset:2022.25 |
(cherry picked from commit 2c16be4)
(cherry picked from commit 2c16be4)
SUMMARY
Limits that were in the sql statement were not being respected in async queries.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-06-22.at.12.26.45.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION