-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding extra metrics issue after chart configuration #20410
fix: Adding extra metrics issue after chart configuration #20410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code wise, let's spin an env to test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix! If it's possible to add a regression test for this (perhaps using Cypress), that would be a nice follow-up
Codecov Report
@@ Coverage Diff @@
## master #20410 +/- ##
=======================================
Coverage 66.70% 66.70%
=======================================
Files 1739 1739
Lines 65135 65135
Branches 6897 6897
=======================================
Hits 43450 43450
Misses 19932 19932
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I successfully tested the branch locally. Lookin' good! |
(cherry picked from commit a8a6b73)
🏷️ preset:2022.23 |
(cherry picked from commit a8a6b73)
SUMMARY
If we set the alignment on some columns, then start adding new metrics, the metrics throw an error and things break.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
[DEV] Explore - birth_names - 16 June 2022 - Watch Video
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION