Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar-chart-v2): remove marker control from bar chart V2 #20409

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

The marker is not used in bar chart v2 (including timeseries), so we remove it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ changed the title fix(bar-chart-v2): remove marker from bar chart V2 fix(bar-chart-v2): remove marker control from bar chart V2 Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20409 (237eafe) into master (c959d92) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20409   +/-   ##
=======================================
  Coverage   66.70%   66.71%           
=======================================
  Files        1739     1739           
  Lines       65135    65134    -1     
  Branches     6897     6897           
=======================================
  Hits        43451    43451           
+ Misses      19931    19930    -1     
  Partials     1753     1753           
Flag Coverage Δ
javascript 51.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 34.48% <ø> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c959d92...237eafe. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review June 17, 2022 02:04
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
btw, in order to maintain easily, we should move the Marker to the sections.

@stephenLYZ stephenLYZ merged commit b32288f into apache:master Jun 17, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants