Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docs on contributing to docs #20400

Merged
merged 1 commit into from
Jun 16, 2022
Merged

docs: Update docs on contributing to docs #20400

merged 1 commit into from
Jun 16, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Jun 15, 2022

SUMMARY

Move Docusaurus instructions from docs/README.md to CONTRIBUTING.MD and add additional context.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml marked this pull request as ready for review June 15, 2022 19:34
@codyml codyml force-pushed the update-docs-contributing-docs branch from eea7394 to f06e6b7 Compare June 16, 2022 16:32
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 16, 2022
rusackas
rusackas approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning house!

@rusackas rusackas merged commit fadf0ec into apache:master Jun 16, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@codyml @akshatsri
Update documentation on updating documentation. (apache#20400)
271a26c
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codyml @rusackas @mistercrunch @michael-s-molina