Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes no-use-before-define warnings #20298

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes no-use-before-define warnings.

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #20298 (b906bfa) into master (ec331e6) will not change coverage.
The diff coverage is 63.15%.

@@           Coverage Diff           @@
##           master   #20298   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files        1738     1738           
  Lines       65060    65060           
  Branches     6885     6885           
=======================================
  Hits        43360    43360           
  Misses      19953    19953           
  Partials     1747     1747           
Flag Coverage Δ
javascript 51.61% <63.15%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 55.31% <20.00%> (ø)
...frontend/src/views/CRUD/welcome/DashboardTable.tsx 54.09% <54.54%> (ø)
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx 62.00% <55.55%> (ø)
superset-frontend/src/middleware/asyncEvent.ts 73.72% <63.41%> (ø)
...ackages/superset-ui-switchboard/src/switchboard.ts 100.00% <100.00%> (ø)
...ols/DateFilterControl/components/AdvancedFrame.tsx 100.00% <100.00%> (ø)
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec331e6...b906bfa. Read the comment docs.

@michael-s-molina michael-s-molina force-pushed the remove-no-use-before-define-warnings branch from cb99380 to b906bfa Compare June 10, 2022 11:21
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michael-s-molina michael-s-molina merged commit cb2ffa5 into apache:master Jun 13, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants