-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: derived metrics use different line style #20242
Conversation
/testenv up |
@stephenLYZ Container image not yet published for this PR. Please try again when build is complete. |
@stephenLYZ Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #20242 +/- ##
=======================================
Coverage 66.48% 66.48%
=======================================
Files 1726 1727 +1
Lines 64790 64798 +8
Branches 6829 6832 +3
=======================================
+ Hits 43076 43083 +7
Misses 19978 19978
- Partials 1736 1737 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@rusackas Ephemeral environment spinning up at http://35.88.137.13:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The legacy line chart(NVD3) with the time shift has a feature that the derived metrics were displayed
dashed line
rather than asolid line
. For example, aLine Chart
has a metric be calledsum(sales)
, and select time shift1 month ago
inAdvanced Analytics
, the line ofsum(sales)
was displayedsolid line
and derived metricsum(sales)__1 month ago
was displayeddashed line
.This PR introduces this feature on the new chart.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
Before
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION