fix(sql lab): SQL Lab Compile Query Delay #20206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's currently a lag when entering a query in the SQL Lab.
If you set some text and immediately submit the query, you'll most likely get the previous stored query executed.
This is specially notorious if you use keyboard shortcuts to fire the query.
This PR removes the sql query stored locally in the component in favor of the one stored in the redux store, to prevent the two states to be out of sync.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
old.mov
After:
new.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION