-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move columns to datasource object for bootstrap data #20203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20203 +/- ##
==========================================
- Coverage 66.46% 66.28% -0.19%
==========================================
Files 1727 1727
Lines 64721 64723 +2
Branches 6823 6823
==========================================
- Hits 43019 42901 -118
- Misses 19970 20090 +120
Partials 1732 1732
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset/views/core.py
Outdated
if datasource: | ||
datasource_data["owners"] = datasource.owners_data | ||
if isinstance(datasource, Query): | ||
columns = datasource.extra.get("columns", []) | ||
datasource_data["columns"] = datasource.extra.get("columns", []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be easier to make a columns
property of the Query model that does this?
* move columns to datasource * address concerns
SUMMARY
Address concern after merge for adding data to datasource object instead of having it's own top level key
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION