Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(security): a typo: Gamma should be in quotes #20185

Merged
merged 1 commit into from
May 25, 2022
Merged

docs(security): a typo: Gamma should be in quotes #20185

merged 1 commit into from
May 25, 2022

Conversation

jimmytheneutrino
Copy link
Contributor

SUMMARY

PUBLIC_ROLE_LIKE = in superset config python files expects "Gamma", not just Gamma.

TESTING INSTRUCTIONS

Test the config option by adding it superset_config_docker.py.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Incidentally I just noticed this yesterday, thanks so much for fixing it!

@villebro villebro merged commit 4674de1 into apache:master May 25, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@jimmytheneutrino @philipher29
fix typo in secutiry.mdx (apache#20185)
57e65c5
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmytheneutrino @villebro @mistercrunch