Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable flaky assert in reports cypress test #20174

Merged
merged 2 commits into from
May 24, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

report list view cypress test keeps failing in multiple PRs. Manual tests prove that the tested feature works correctly, therefore we can assume the test is flaky. This PR disables 1 assert in the test suite that usually fails.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #20174 (5d3d5d0) into master (b746e6f) will decrease coverage by 0.01%.
The diff coverage is 23.25%.

❗ Current head 5d3d5d0 differs from pull request most recent head 2658219. Consider uploading reports for the commit 2658219 to get more accurate results

@@            Coverage Diff             @@
##           master   #20174      +/-   ##
==========================================
- Coverage   66.46%   66.44%   -0.02%     
==========================================
  Files        1721     1721              
  Lines       64521    64548      +27     
  Branches     6811     6811              
==========================================
+ Hits        42882    42890       +8     
- Misses      19906    19925      +19     
  Partials     1733     1733              
Flag Coverage Δ
javascript 51.32% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...c/SqlLab/components/ExploreResultsButton/index.tsx 100.00% <ø> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <ø> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 55.31% <ø> (ø)
superset/datasets/filters.py 86.95% <70.00%> (-13.05%) ⬇️
superset/datasets/api.py 88.34% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b746e6f...2658219. Read the comment docs.

@pkdotson pkdotson merged commit ce547f4 into apache:master May 24, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* chore: Disable flaky assert in reports cypress test

* Disable flaky assert in alerts cypress test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants