feat: add modfied col and timezone info to schedule col #20165

pkdotson · 2022-05-23T22:16:01Z

SUMMARY

This pr add modfied to alerts and reports and add timezone information to schedule column

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

TESTING INSTRUCTIONS

Go to alerts and reports there should be modified column and time zone information in the schedule column.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-05-23T22:50:55Z

Codecov Report

Merging #20165 (72ece59) into master (2a1dcaf) will increase coverage by 0.12%.
The diff coverage is 79.41%.

❗ Current head 72ece59 differs from pull request most recent head 5022e34. Consider uploading reports for the commit 5022e34 to get more accurate results

@@            Coverage Diff             @@
##           master   #20165      +/-   ##
==========================================
+ Coverage   66.52%   66.65%   +0.12%     
==========================================
  Files        1726     1729       +3     
  Lines       64886    64910      +24     
  Branches     6832     6842      +10     
==========================================
+ Hits        43168    43268     +100     
+ Misses      19986    19893      -93     
- Partials     1732     1749      +17

Flag	Coverage Δ
javascript	`51.57% <83.07%> (+0.23%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts	`100.00% <ø> (ø)`
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx	`25.00% <0.00%> (-8.34%)`	⬇️
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx	`33.33% <0.00%> (-6.67%)`	⬇️
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx	`33.33% <0.00%> (-6.67%)`	⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts	`58.33% <0.00%> (-0.62%)`	⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts	`50.40% <ø> (ø)`
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx	`9.09% <0.00%> (-3.41%)`	⬇️
superset/models/core.py	`89.15% <0.00%> (ø)`
superset/utils/async_query_manager.py	`81.18% <0.00%> (ø)`
...et-frontend/src/explore/reducers/exploreReducer.js	`34.78% <50.00%> (-1.16%)`	⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1dcaf...5022e34. Read the comment docs.

…eat-add-timezone

yousoph · 2022-06-02T20:32:19Z

/testenv up

github-actions · 2022-06-02T20:34:39Z

@yousoph Ephemeral environment spinning up at http://54.218.198.97:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

yousoph · 2022-06-03T07:34:23Z

/testenv up FEATURE_ALERT_REPORTS = True

github-actions · 2022-06-03T07:38:42Z

@yousoph Ephemeral environment spinning up at http://52.43.5.216:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2022-06-03T07:46:14Z

Ephemeral environment shutdown and build artifacts deleted.

yousoph · 2022-06-03T08:02:46Z

/testenv up FEATURE_ALERT_REPORTS = True

github-actions · 2022-06-03T08:03:55Z

@yousoph Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2022-06-03T08:03:56Z

@yousoph Ephemeral environment creation failed. Please check the Actions logs for details.

yousoph · 2022-06-03T08:22:34Z

/testenv up FEATURE_ALERT_REPORTS = True

github-actions · 2022-06-03T08:24:44Z

@yousoph Ephemeral environment spinning up at http://54.186.233.208:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…eat-add-timezone

lyndsiWilliams · 2022-06-03T19:50:39Z

superset-frontend/cypress-base/cypress/integration/alerts_and_reports/alerts.test.ts

@@ -32,14 +32,17 @@ describe('alert list view', () => {

    cy.get('[data-test="listview-table"]').should('be.visible');
    // check alert list view header
+    cy.wait(500);
+    /// cy.get('[data-test="sort-header"]').debug()


There's a debug line here, this should be deleted right?

github-actions · 2022-06-06T16:41:29Z

Ephemeral environment shutdown and build artifacts deleted.

feat: add modfied and timezone to to schedule col

52131a1

superset-github-bot bot added the preset-io label May 23, 2022

pull-request-size bot added the size/S label May 23, 2022

pkdotson changed the title ~~feat: add modfied and timezone to to schedule col~~ feat: add modfied col and timezone info to schedule col May 23, 2022

pkdotson added 3 commits May 24, 2022 13:59

Merge branch 'master' of https://github.com/preset-io/superset into f…

999ae91

…eat-add-timezone

Merge branch 'master' of https://github.com/preset-io/superset into f…

3096d5a

…eat-add-timezone

test if test works

985e042

yousoph closed this Jun 3, 2022

yousoph reopened this Jun 3, 2022

pkdotson added 2 commits June 3, 2022 09:16

Merge branch 'master' of https://github.com/preset-io/superset into f…

7f63c48

…eat-add-timezone

udpate test

479a266

pkdotson requested review from AAfghahi, hughhhh and lyndsiWilliams June 3, 2022 17:30

hughhhh approved these changes Jun 3, 2022

View reviewed changes

lyndsiWilliams reviewed Jun 3, 2022

View reviewed changes

fix test

5022e34

pkdotson merged commit 6f0d53e into apache:master Jun 6, 2022

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add modfied col and timezone info to schedule col #20165

feat: add modfied col and timezone info to schedule col #20165

pkdotson commented May 23, 2022 •

edited

Loading

codecov bot commented May 23, 2022 •

edited

Loading

yousoph commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

lyndsiWilliams Jun 3, 2022

github-actions bot commented Jun 6, 2022

feat: add modfied col and timezone info to schedule col #20165

feat: add modfied col and timezone info to schedule col #20165

Conversation

pkdotson commented May 23, 2022 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented May 23, 2022 • edited Loading

Codecov Report

yousoph commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

yousoph commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

lyndsiWilliams Jun 3, 2022

Choose a reason for hiding this comment

github-actions bot commented Jun 6, 2022

pkdotson commented May 23, 2022 •

edited

Loading

codecov bot commented May 23, 2022 •

edited

Loading