-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql lab): View result button is not showing consistently #20164
fix(sql lab): View result button is not showing consistently #20164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20164 +/- ##
==========================================
- Coverage 66.44% 66.44% -0.01%
==========================================
Files 1721 1721
Lines 64537 64538 +1
Branches 6811 6811
==========================================
- Hits 42882 42881 -1
- Misses 19922 19924 +2
Partials 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://34.221.127.135:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. @jinghua-qa did you give this a test? If not, @yousoph and I can.
Andrey tested, good to merge |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
In order to display the 'View' button in the history tab of the SQL Lab, the query must have a resultsKey.
When the query is executed in sync mode, that key was not properly propagated from the API to the FE, thus, the button did not appeared after execution.
The button did appeared once the running polling watching for queries updated, since that fetches fresh results from the api.
This PR forwards that key to make the button show for every successfully executed query.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
160002524-d03da706-ab0a-4d6f-b404-639fc12d5a73.mov
After:
Screen.Recording.2022-05-23.at.18.52.14.mov
TESTING INSTRUCTIONS
Ensure that, if the queries are successful, the 'View' button always displays.
Ensure it works for both sync/async query execution flows.
ADDITIONAL INFORMATION