Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): retrival of tables and views from schema for exasol backend #20127

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

Nicoretti
Copy link
Contributor

@Nicoretti Nicoretti commented May 19, 2022

SUMMARY

Updates the dependencies of the exasol feature flag, to address #20105 which have been caused by a bug in the sqlalchemy-exasol dependency.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

  1. Go to 'Datasets'
  2. Click on '+ DATASET'
  3. Select the Exasol DB as database
  4. Select a schema containing views and tables
  5. Try to select a Table/Schema
  6. No Tables/Schemas are shown

For more details see #20105

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20127 (7aee3ee) into master (660af40) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 7aee3ee differs from pull request most recent head af37e6f. Consider uploading reports for the commit af37e6f to get more accurate results

@@            Coverage Diff             @@
##           master   #20127      +/-   ##
==========================================
- Coverage   66.47%   66.30%   -0.17%     
==========================================
  Files        1721     1721              
  Lines       64477    64477              
  Branches     6795     6795              
==========================================
- Hits        42858    42750     -108     
- Misses      19891    19999     +108     
  Partials     1728     1728              
Flag Coverage Δ
hive ?
mysql 82.14% <ø> (ø)
postgres 82.20% <ø> (ø)
presto ?
python 82.28% <ø> (-0.35%) ⬇️
sqlite 81.94% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.22% <0.00%> (-15.65%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-5.34%) ⬇️
superset/connectors/sqla/models.py 88.39% <0.00%> (-1.19%) ⬇️
superset/initialization/__init__.py 91.13% <0.00%> (-0.36%) ⬇️
superset/db_engine_specs/base.py 88.08% <0.00%> (-0.34%) ⬇️
superset/models/core.py 88.91% <0.00%> (-0.25%) ⬇️
superset/utils/core.py 90.02% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 660af40...af37e6f. Read the comment docs.

@betodealmeida betodealmeida merged commit ac4158e into apache:master May 26, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
Updating the sqlalchemy-exasol package will fix apache#20105 .
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dataset does not work for Exasol backend when using pydobc based sqlalchemy dialect
3 participants