Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set limit for a query in execute_sql_statement #20066

Merged
merged 2 commits into from
May 16, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented May 13, 2022

SUMMARY

For Async queries, the limit was not being passed into the query object. This had the adverse effect of making it so that there was no limit when returning a query in SQL Lab.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #20066 (d0652b9) into master (62e1c34) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head d0652b9 differs from pull request most recent head 0149444. Consider uploading reports for the commit 0149444 to get more accurate results

@@            Coverage Diff             @@
##           master   #20066      +/-   ##
==========================================
+ Coverage   66.28%   66.43%   +0.14%     
==========================================
  Files        1712     1719       +7     
  Lines       63968    64334     +366     
  Branches     6731     6731              
==========================================
+ Hits        42404    42739     +335     
- Misses      19853    19884      +31     
  Partials     1711     1711              
Flag Coverage Δ
hive 53.69% <ø> (+0.03%) ⬆️
mysql 82.13% <ø> (+0.13%) ⬆️
postgres 82.19% <ø> (+0.14%) ⬆️
presto 53.55% <ø> (+0.03%) ⬆️
python 82.58% <ø> (+0.10%) ⬆️
sqlite ?
unit 49.39% <ø> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sqllab/sqllab_execution_context.py 90.55% <ø> (ø)
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 88.75% <0.00%> (-2.50%) ⬇️
superset/result_set.py 96.85% <0.00%> (-1.58%) ⬇️
superset/databases/commands/test_connection.py 98.59% <0.00%> (-1.41%) ⬇️
superset/models/slice.py 84.95% <0.00%> (-0.49%) ⬇️
superset/sql_validators/presto_db.py 82.43% <0.00%> (-0.47%) ⬇️
superset/connectors/sqla/models.py 89.57% <0.00%> (-0.38%) ⬇️
superset/db_engine_specs/base.py 88.08% <0.00%> (-0.21%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e1c34...0149444. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tests/integration_tests/celery_tests.py Outdated Show resolved Hide resolved
@AAfghahi AAfghahi merged commit e69f629 into apache:master May 16, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants