-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set limit for a query in execute_sql_statement #20066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20066 +/- ##
==========================================
+ Coverage 66.28% 66.43% +0.14%
==========================================
Files 1712 1719 +7
Lines 63968 64334 +366
Branches 6731 6731
==========================================
+ Hits 42404 42739 +335
- Misses 19853 19884 +31
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a4f9f0f
to
1a65f70
Compare
1a65f70
to
941fbf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
d0652b9
to
d3c82b7
Compare
d3c82b7
to
0149444
Compare
* test for query limit * fixed tests
SUMMARY
For Async queries, the limit was not being passed into the query object. This had the adverse effect of making it so that there was no limit when returning a query in SQL Lab.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION