-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a generic header component for Explore and Dashboard #20044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20044 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1712 1713 +1
Lines 64080 64102 +22
Branches 6744 6746 +2
=======================================
+ Hits 42520 42538 +18
- Misses 19847 19849 +2
- Partials 1713 1715 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@kgabryje Ephemeral environment spinning up at http://35.162.156.179:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
…pache#20044) * chore: Create a generic header component for Explore and Dashboard * Add tests * Fix undefined error * Remove duplicate code * Fix cypress test
SUMMARY
This PR implements a generic Header component for Explore and Dashboard pages. The goal is to be able to reuse the header already implemented in Explore and use it in Dashboards, thus unblocking the redesign of dashboard header project.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
Explore header should work exactly like before
ADDITIONAL INFORMATION