Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use pull_request_target in Cypress Applitools workflow #19996

Merged
merged 1 commit into from
May 9, 2022

Conversation

geido
Copy link
Member

@geido geido commented May 9, 2022

SUMMARY

The Applitools API key is not present when a PR is launched by a fork. Using the pull_request_target should launch the workflow from the target branch and should avoid failure. This is a temporary change to unblock CI.

Read this for more context: https://github.community/t/can-workflow-changes-be-used-with-pull-request-target/178626

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #19996 (c576dcb) into master (b7cff83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19996   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1712     1712           
  Lines       63968    63968           
  Branches     6731     6731           
=======================================
  Hits        42404    42404           
  Misses      19853    19853           
  Partials     1711     1711           
Flag Coverage Δ
hive 53.65% <ø> (ø)
javascript 51.27% <ø> (ø)
mysql 81.99% <ø> (ø)
postgres 82.04% <ø> (ø)
presto 53.51% <ø> (ø)
python 82.47% <ø> (ø)
sqlite 81.78% <ø> (ø)
unit 48.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7cff83...c576dcb. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense, so approving to unblock - Tagging this PR as it's related (let's make sure we address all the concerns raised in the associated PRs/articles): #12241

@geido geido merged commit 62e1c34 into master May 9, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/applitools-target branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants