fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846) #19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19972 +/- ##
=======================================
Coverage 66.29% 66.29%
=======================================
Files 1712 1712
Lines 63962 63962
Branches 6731 6731
=======================================
Hits 42404 42404
Misses 19847 19847
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
villebro
changed the title
|
LGTM! Let's migrate to Echarts version next! |
Agreed @stephenLYZ , it seems like a perfect drop in replacement! |
villebro
added a commit
that referenced
this pull request
May 6, 2022
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
May 6, 2022
More hackery! removing some giant padding lint add dedicated mobile collapse button style action buttons replace down with up arrow Make it sticky Adding viewport tag Making Filters a Sidebar Again (and letting the header scroll away) delint Revert "chore(deps): bump d3-svg-legend in /superset-frontend (apache#19846)" (apache#19972) This reverts commit 528a9cd. customize font sizes
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…#19846)" (apache#19972) This reverts commit 528a9cd.
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…#19846)" (apache#19972) This reverts commit 528a9cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
d3-svg-legendversion 2 is incompatible withd3version 3 (see: susielu/d3-legend#58), causing the Heatmap chart to fail to render. I contemplated the option of bumpingd3to version 4, but decided against it due to the following reasons:d3version 4 and would have required fairly big changesd3is now on version 7d3-svg-legendhas been stale for 4 yearsInstead I think we should just migrate this plugin to
d3version 7 or the equivalent ECharts version (https://echarts.apache.org/examples/en/editor.html?c=heatmap-cartesian) while migrating this plugin to the v1 chart data endpoint.Related PR: #19846
AFTER
BEFORE
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION