Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart & alert): make to show metrics properly #19939

Merged
merged 4 commits into from
May 16, 2022
Merged

fix(chart & alert): make to show metrics properly #19939

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dae3bdc
fix(chart & alert): make to show metrics properly
prosdev0107 May 3, 2022
02fb6ef
fix(chart & alert): make to remove duplicate metrics
prosdev0107 May 4, 2022
30d7f09
fix(chart & alert): make to restore metrics control alert slice
prosdev0107 May 4, 2022
057e5d3
fix(chart & alert): make to fix lint issue
prosdev0107 May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(chart & alert): make to restore metrics control alert slice
  • Loading branch information
@prosdev0107
prosdev0107 committed May 4, 2022
commit 30d7f097e9492779b9e03a93c5e41a527bc33528
6 changes: 5 additions & 1 deletion superset-frontend/src/components/AlteredSliceTag/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,15 @@ export default class AlteredSliceTag extends React.Component {
if (controlsMap[key]?.type === 'CollectionControl') {
return value.map(v => safeStringify(v)).join(', ');
}
if (controlsMap[key]?.type === 'MetricsControl' && value.constructor === Array) {
const formattedValue = value.map(v => (v?.label ?? v));
return formattedValue.length ? formattedValue.join(', ') : '[]';
}
if (typeof value === 'boolean') {
return value ? 'true' : 'false';
}
if (value.constructor === Array) {
const formattedValue = value.map(v => (v.label ? v.label : v));
const formattedValue = value.map(v => (v?.label ?? v));
return formattedValue.length ? formattedValue.join(', ') : '[]';
}
if (typeof value === 'string' || typeof value === 'number') {
Expand Down